allow to override namespace for serviceMonitor, and use new value for… #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configMap for grafana dashboards Signed-off-by: Thomas Labarussias <thomas.labarussias@qonto.com>
fjogeleit
approved these changes
Aug 20, 2021
Pull Request Test Coverage Report for Build 1149977419
💛 - Coveralls |
|
Thank you and welcome on board |
|
I forgot to override the helm chart version, is that an issue? |
|
No, I was also working on the helm chart and changed it together with my changes Your PR is released with https://github.com/kyverno/policy-reporter/releases/tag/policy-reporter-1.8.7 |
fjogeleit
pushed a commit
that referenced
this pull request
Aug 20, 2021
Merge pull request #57 from Issif/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces: